linux-kernel - Re: [PATCH -v3] flat: fix data sections alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090310073350.GH10393@linux-sh.org>
Date:	Tue, 10 Mar 2009 16:33:50 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Oskar Schirmer <os@...ix.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <jw@...ix.com>,
	David Howells <dhowells@...hat.com>,
	Russell King <rmk@....linux.org.uk>,
	Bryan Wu <cooloney@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mike Frysinger <vapier.adi@...il.com>,
	Greg Ungerer <gerg@...inux.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -v3] flat: fix data sections alignment

On Thu, Mar 05, 2009 at 06:00:59PM +0100, Oskar Schirmer wrote:
> The flat loader uses an architecture's flat_stack_align() to align the
> stack but assumes word-alignment is enough for the data sections.
> 
> However, on the Xtensa S6000 we have registers up to 128bit width
> which can be used from userspace and therefor need userspace stack and
> data-section alignment of at least this size.
> 
> This patch drops flat_stack_align() and uses the same alignment that
> is required for slab caches, ARCH_SLAB_MINALIGN, or wordsize if it's
> not defined by the architecture.
> 
> It also fixes m32r which was obviously kaput, aligning an
> uninitialized stack entry instead of the stack pointer.
> 
> Signed-off-by: Oskar Schirmer <os@...ix.com>
> Signed-off-by: Johannes Weiner <jw@...ix.com>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Russell King <rmk@....linux.org.uk>
> Cc: Bryan Wu <cooloney@...nel.org>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Paul Mundt <lethal@...ux-sh.org>
> Cc: Greg Ungerer <gerg@...inux.org>
> Cc: Mike Frysinger <vapier.adi@...il.com>

The updated version looks ok to me anyways, and it's certainly an
improvement over defining the same alignment requirements all over the
place.

Acked-by: Paul Mundt <lethal@...ux-sh.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/