linux-kernel - Re: [PATCH 09/25] [s390] BUG to BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 12:17:54 +0100
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	Stoyan Gaydarov <stoyboyker@...il.com>
Cc:	linux-kernel@...r.kernel.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux-s390@...r.kernel.org
Subject: Re: [PATCH 09/25] [s390] BUG to BUG_ON changes

Am Tuesday 10 March 2009 06:10:34 schrieb Stoyan Gaydarov:
> +++ b/drivers/s390/char/tape_std.c
> @@ -39,8 +39,8 @@ tape_std_assign_timeout(unsigned long data)
>  	int rc;
> 
>  	request = (struct tape_request *) data;
> -	if ((device = request->device) == NULL)
> -		BUG();
> +	device = request->device;
> +	BUG_ON(device == NULL);
> 
>  	DBF_EVENT(3, "%08x: Assignment timeout. Device busy.\n",
>  			device->cdev_id);

Most of the patch look good. Since !pointer seems to be preferred over 
pointer == NULL, this hunk can be changed to 

BUG_ON(!device);

Christian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/