linux-kernel - Re: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0903100429t22515ebav286eb9447fc41a93@mail.gmail.com>
Date:	Tue, 10 Mar 2009 07:29:56 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	graff yang <graff.yang@...il.com>
Cc:	samuel@...tiz.org, irda-users@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, graf.yang@...log.com,
	cooloney@...nel.org
Subject: Re: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver

On Tue, Mar 10, 2009 at 07:25, graff yang wrote:
> On Tue, Mar 10, 2009 at 4:03 PM, Mike Frysinger wrote:
>> On Tue, Mar 10, 2009 at 03:29,  <graff.yang@...il.com> wrote:
>> > +       baudrate_mask = IR_9600;
>> > +
>> > +       switch (max_rate) {
>> > +       case 115200:
>> > +               baudrate_mask |= IR_115200;
>> > +       case 57600:
>> > +               baudrate_mask |= IR_57600;
>> > +       case 38400:
>> > +               baudrate_mask |= IR_38400;
>> > +       case 19200:
>> > +               baudrate_mask |= IR_19200;
>> > +       }
>>
>> what if someone specified max_rate = 1231245 ?
>
> The  initial value of baudrate_mask is IR_9600.

i meant in terms of the user being notified it's a bogus value.  what
if they did max_rate=576000 ?  clearly they meant 57600, but they hit
"0" too many times ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/