linux-kernel - Re: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 07:53:03 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	gyang <graf.yang@...log.com>
Cc:	graff yang <graff.yang@...il.com>, samuel@...tiz.org,
	irda-users@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	cooloney@...nel.org
Subject: Re: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver

On Tue, Mar 10, 2009 at 07:48, gyang wrote:
> On Tue, 2009-03-10 at 19:25 +0800, graff yang wrote:
>> On Tue, Mar 10, 2009 at 4:03 PM, Mike Frysinger wrote:
>>> On Tue, Mar 10, 2009 at 03:29,  <graff.yang@...il.com> wrote:
>>>> +               do {
>>>> +                       lsr = SIR_UART_GET_LSR(port);
>>>> +               } while (!(lsr & TEMT));
>>
>>
>>> i'm pretty sure we determined that it is not the job of the
>>> kernel to
>>> make sure the line is clear before we go changing speeds.
>
> But we should prevent changing speed when the byte is sending out.

no we shouldnt.  if the user changes speeds while things are being
transmitted, then they screwed up.  this is why tcdrain/tcflush exist
on the tty side of things.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/