linux-kernel - Re: [PATCH] Free setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090310124123.GF5794@elte.hu>
Date:	Tue, 10 Mar 2009 13:41:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	linux-kernel@...r.kernel.org, lethal@...ux-sh.org,
	tglx@...utronix.de, akpm@...ux-foundation.org
Subject: Re: [PATCH] Free setup_irq() interrupt V2


* Magnus Damm <magnus.damm@...il.com> wrote:

> From: Magnus Damm <damm@...l.co.jp>
> 
> This patch adds a __free_irq() function for releasing 
> interrupts requested with setup_irq().
> 
> Without this patch we have no way of releasing such
> interrupts since free_irq() today tries to kfree()
> the irqaction passed with setup_irq().
> 
> Signed-off-by: Magnus Damm <damm@...l.co.jp>
> ---
> 
>  Changes since V1:
>  - break out a __free_irq() function, thanks Ingo! 

Looks good. Could you please send it against the latest genirq 
tree:

  http://people.redhat.com/mingo/tip.git/README

as your patch does not apply cleanly anymore:

  1 out of 3 hunks FAILED -- rejects in file kernel/irq/manage.c

>  Why again are we not using struct list_head for the irqaction list?

irq_desc size mostly.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/