linux-kernel - Re: [patch 2/2] fs: introduce mnt_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090310150841.GB8579@wotan.suse.de>
Date:	Tue, 10 Mar 2009 16:08:41 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Hansen <haveblue@...ibm.com>
Subject: Re: [patch 2/2] fs: introduce mnt_clone_write

On Tue, Mar 10, 2009 at 08:55:58AM -0600, Matthew Wilcox wrote:
> On Tue, Mar 10, 2009 at 03:38:01PM +0100, Nick Piggin wrote:
> > +EXPORT_SYMBOL_GPL(mnt_clone_write);
> > +EXPORT_SYMBOL_GPL(mnt_want_write_file);
> 
> You don't add any users of these functions in this patch ... is there a
> good reason to export them?

Only to encourage modular code to use them (as a replacement for
mnt_want_write -- which itself is exported).

If that's not the right way to go, I don't mind waiting for a
user to turn up.


[I see many ioctls in btrfs (coming first in the alphabet) could
probably easily use mnt_want_write_file (otoh probably none are
so performance critical).]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/