| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Mar 2009 18:03:53 +0200 From: Atal Shargorodsky <ext-atal.shargorodsky@...ia.com> To: linux-kernel@...r.kernel.org Cc: linux@....linux.org.uk, Atal Shargorodsky <ext-atal.shargorodsky@...ia.com> Subject: [PATCH 3/6] Remove non-explanatory comments. The call to clk_disable does need a trivial comment like /* Disable the clock */. Signed-off-by: Atal Shargorodsky <ext-atal.shargorodsky@...ia.com> --- drivers/watchdog/omap_wdt.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c index 05dc55a..1364d7e 100644 --- a/drivers/watchdog/omap_wdt.c +++ b/drivers/watchdog/omap_wdt.c @@ -146,9 +146,9 @@ static int omap_wdt_open(struct inode *inode, struct file *file) return -EBUSY; if (wdev->mpu_wdt_ick) - clk_enable(wdev->mpu_wdt_ick); /* Enable the interface clock */ + clk_enable(wdev->mpu_wdt_ick); - clk_enable(wdev->mpu_wdt_fck); /* Enable the functional clock */ + clk_enable(wdev->mpu_wdt_fck); /* initialize prescaler */ while (__raw_readl(base + OMAP_WATCHDOG_WPS) & 0x01) @@ -178,9 +178,9 @@ static int omap_wdt_release(struct inode *inode, struct file *file) omap_wdt_disable(wdev); if (wdev->mpu_wdt_ick) - clk_disable(wdev->mpu_wdt_ick); /* Disable the clock */ + clk_disable(wdev->mpu_wdt_ick); - clk_disable(wdev->mpu_wdt_fck); /* Disable the clock */ + clk_disable(wdev->mpu_wdt_fck); #else printk(KERN_CRIT "omap_wdt: Unexpected close, not stopping!\n"); #endif @@ -345,9 +345,9 @@ static int __init omap_wdt_probe(struct platform_device *pdev) /* enable clocks for register access */ if (wdev->mpu_wdt_ick) - clk_enable(wdev->mpu_wdt_ick); /* Enable the interface clock */ + clk_enable(wdev->mpu_wdt_ick); - clk_enable(wdev->mpu_wdt_fck); /* Enable the functional clock */ + clk_enable(wdev->mpu_wdt_fck); omap_wdt_disable(wdev); omap_wdt_adjust_timeout(timer_margin); @@ -370,8 +370,8 @@ static int __init omap_wdt_probe(struct platform_device *pdev) /* disable clocks since we don't need them now */ if (wdev->mpu_wdt_ick) - clk_disable(wdev->mpu_wdt_ick); /* Disable the clock */ - clk_disable(wdev->mpu_wdt_fck); /* Disable the clock */ + clk_disable(wdev->mpu_wdt_ick); + clk_disable(wdev->mpu_wdt_fck); omap_wdt_dev = pdev; -- 1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists