linux-kernel - Re: [PATCH 22/31] i2c: Auto-load i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 17:56:12 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Scott James Remnant <scott@...onical.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 22/31] i2c: Auto-load i2c_dev module when device opened.

Scott,

Your clock is off by a significant number of days, isn't it?

On Mon, 2 Mar 2009 18:41:51 +0000, Scott James Remnant wrote:
> The i2c_dev module is missing the char-major-89-* alias that would cause
> it to be auto-loaded when a device of that type is opened.  This patch
> adds the alias.

Why not, however this is pretty pointless nowadays as /dev nodes tend
to be created dynamically by udev, so there is no way i2c-dev will
auto-load.

> Signed-off-by: Scott James Remnant <scott@...onical.com>
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> ---
>  drivers/i2c/i2c-dev.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index 7e13d2d..f3f83ba 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -618,6 +618,7 @@ MODULE_AUTHOR("Frodo Looijaard <frodol@....nl> and "
>  		"Simon G. Vogl <simon@...uni-linz.ac.at>");
>  MODULE_DESCRIPTION("I2C /dev entries driver");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS_CHARDEV_MAJOR(I2C_MAJOR);
>  
>  module_init(i2c_dev_init);
>  module_exit(i2c_dev_exit);


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/