linux-kernel - Re: [patch] fs: avoid I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090311122251.GA24590@duck.suse.cz>
Date:	Wed, 11 Mar 2009 13:22:52 +0100
From:	Jan Kara <jack@...e.cz>
To:	Nick Piggin <npiggin@...e.de>
Cc:	linux-fsdevel@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Jorge Boncompte [DTI2]" <jorge@...2.net>,
	Adrian Hunter <ext-adrian.hunter@...ia.com>, stable@...nel.org
Subject: Re: [patch] fs: avoid I_NEW inodes

On Wed 11-03-09 03:34:30, Nick Piggin wrote:
> On Tue, Mar 10, 2009 at 05:03:21PM +0100, Jan Kara wrote:
> > > Index: linux-2.6/fs/drop_caches.c
> > > ===================================================================
> > > --- linux-2.6.orig/fs/drop_caches.c
> > > +++ linux-2.6/fs/drop_caches.c
> > > @@ -18,7 +18,7 @@ static void drop_pagecache_sb(struct sup
> > >  
> > >  	spin_lock(&inode_lock);
> > >  	list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
> > > -		if (inode->i_state & (I_FREEING|I_WILL_FREE))
> > > +		if (inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW))
> > >  			continue;
> > >  		if (inode->i_mapping->nrpages == 0)
> > >  			continue;
> > > Index: linux-2.6/fs/inode.c
> > > ===================================================================
> > > --- linux-2.6.orig/fs/inode.c
> > > +++ linux-2.6/fs/inode.c
> > > @@ -356,6 +356,8 @@ static int invalidate_list(struct list_h
> > >  		if (tmp == head)
> > >  			break;
> > >  		inode = list_entry(tmp, struct inode, i_sb_list);
> > > +		if (inode->i_state & I_NEW)
> > > +			continue;
> >   If somebody is setting up inodes at this point, we are in serious
> > trouble I think. So WARN_ON would be more appropriate I think.
> 
> Really? Hmm, this is also called via flush_disk which seems like it
> can operate under a mounted filesystem?
  Ah, I was not following calls far enough. You're right.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/