linux-kernel - Re: 2.6.29-rc "TKIP: replay detected" regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090311151102.GC8761@tuxdriver.com>
Date:	Wed, 11 Mar 2009 11:11:02 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: 2.6.29-rc "TKIP: replay detected" regression

On Wed, Mar 11, 2009 at 12:07:54PM +0000, Hugh Dickins wrote:
> Prior to 2.6.29-rc1's 274bfb8dc5ffa16cb073801bebe76ab7f4e2e73d
> "lib80211: absorb crypto bits from net/ieee80211", the TKIP and CCMP
> "replay detected" messages were subject to the IEEE80211_DEBUG_DROP()
> macro, neither I nor my distro had CONFIG_IEEE80211_DEBUG set, I never
> glimpsed such messages, and ThinkPad T43p ipw2200 wireless worked fine.
> 
> -		if (ieee80211_ratelimit_debug(IEEE80211_DL_DROP)) {
> -			IEEE80211_DEBUG_DROP("TKIP: replay detected: STA=%pM"
> +		if (net_ratelimit()) {
> +			printk(KERN_DEBUG "TKIP: replay detected: STA=%pM"

Hugh, this is my mess -- sorry!  I'll follow-up with a patch.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/