linux-kernel - Re: [PATCH] proc: fix kflags to uflags copying in /proc/kpageflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090311101612.A7FD.A69D9226@jp.fujitsu.com>
Date:	Wed, 11 Mar 2009 10:17:58 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	kosaki.motohiro@...fujitsu.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	stable@...nel.org, LKML <linux-kernel@...r.kernel.org>,
	Matt Mackall <mpm@...enic.com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH] proc: fix kflags to uflags copying in /proc/kpageflags

> Fix kpf_copy_bit(src,dst) to be kpf_copy_bit(dst,src) to match the
> actual call patterns, e.g. kpf_copy_bit(kflags, KPF_LOCKED, PG_locked).
> 
> This misplacement of src/dst only affected reporting of PG_writeback,
> PG_reclaim and PG_buddy. For others kflags==uflags so not affected.
> 
> Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> ---
> 
> This is a tested and trivial no-side-effect fix.
> I'd suggest it for 2.6.29-rc7 and 2.6.28.X kernels.
> 
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index 2d13451..e998383 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -80,7 +80,7 @@ static const struct file_operations proc_kpagecount_operations = {
>  #define KPF_RECLAIM    9
>  #define KPF_BUDDY     10
>  
> -#define kpf_copy_bit(flags, srcpos, dstpos) (((flags >> srcpos) & 1) << dstpos)
> +#define kpf_copy_bit(flags, dstpos, srcpos) (((flags >> srcpos) & 1) << dstpos)

Good catch! :)
	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


but don't worry. the number of this interface user is very few.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/