linux-kernel - Re: linux-next: NCR_700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090311040730.GA29678@kroah.com>
Date:	Tue, 10 Mar 2009 21:07:30 -0700
From:	Greg KH <greg@...ah.com>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	linux-next@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, Linux/m68k <linux-m68k@...r.kernel.org>
Subject: Re: linux-next: NCR_700_detect warnings

On Wed, Mar 11, 2009 at 09:59:09AM +0800, Ming Lei wrote:
> 2009/3/11 Geert Uytterhoeven <geert@...ux-m68k.org>:
> > commit 76afea5b078d36ec080a75c29ff5a3fbc5774fee
> > Author: Ming Lei <tom.leiming@...il.com>
> > Date:   Fri Feb 6 23:40:12 2009 +0800
> >
> >    platform driver: fix incorrect use of 'platform_bus_type' with 'struct devic
> >
> >    This patch fixes the bug reported in
> >        http://bugzilla.kernel.org/show_bug.cgi?id=11681.
> >
> >    "Lots of device drivers register a 'struct device_driver' with
> >    the '.bus' member set to '&platform_bus_type'. This is wrong,
> >    since the platform_bus functions expect the 'struct device_driver'
> >    to be wrapped up in a 'struct platform_driver' which provides
> >    some additional callbacks (like suspend_late, resume_early).
> >    The effect may be that platform_suspend_late() uses bogus data
> >    outside the device_driver struct as a pointer pointer to the
> >    device driver's suspend_late() function or other hard to
> >    reproduce failures."(Lothar Wassmann)
> >
> >    Signed-off-by: Ming Lei <tom.leiming@...il.com>
> >    Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>
> >    Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>
> >    Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> >
> > This introduced the following warnings on m68k, as `dev' is now a
> > `struct platform_device *' instead of a `struct device *':
> >
> > | drivers/scsi/a4000t.c:64: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
> > | drivers/scsi/mvme16x_scsi.c:67: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
> > | drivers/scsi/bvme6000_scsi.c:61: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
> >
> > I think the below is missing (untested on real hardware)?
> 
> Yes, you are correct. It is really missed.

Great, Geert, care to resend with a signed-off-by: so I can apply this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/