linux-kernel - Re: [PATCH] x86: relocs is only used with 32bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B88F80.3080203@zytor.com>
Date:	Wed, 11 Mar 2009 21:28:48 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: relocs is only used with 32bit

Hi Yinghai,

In general I prefer minimizing the conditional sections rather than
maximizing them.  If nothing else, it catches errors earlier that way,
and makes it easier to eventually eliminate them entirely.

	-hpa

Yinghai Lu wrote:
> Impact: cleanup
> 
> those lines is not needed for 64bit
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> 
> ---
>  arch/x86/boot/compressed/Makefile |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: linux-2.6/arch/x86/boot/compressed/Makefile
> ===================================================================
> --- linux-2.6.orig/arch/x86/boot/compressed/Makefile
> +++ linux-2.6/arch/x86/boot/compressed/Makefile
> @@ -26,6 +26,7 @@ OBJCOPYFLAGS_vmlinux.bin :=  -R .comment
>  $(obj)/vmlinux.bin: vmlinux FORCE
>  	$(call if_changed,objcopy)
>  
> +ifeq ($(CONFIG_X86_32),y)
>  
>  targets += vmlinux.bin.all vmlinux.relocs relocs
>  hostprogs-$(CONFIG_X86_32) += relocs
> @@ -42,8 +43,6 @@ quiet_cmd_relocbin = BUILD   $@
>  $(obj)/vmlinux.bin.all: $(vmlinux.bin.all-y) FORCE
>  	$(call if_changed,relocbin)
>  
> -ifeq ($(CONFIG_X86_32),y)
> -
>  ifdef CONFIG_RELOCATABLE
>  $(obj)/vmlinux.bin.gz: $(obj)/vmlinux.bin.all FORCE
>  	$(call if_changed,gzip)


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/