lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Mar 2009 08:28:55 +0100 From: Takashi Iwai <tiwai@...e.de> To: Jiri Slaby <jirislaby@...il.com> Cc: linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz> Subject: Re: [PATCH 1/2] sound: pcm_oss, fix locking typo At Wed, 11 Mar 2009 20:11:40 +0100, Jiri Slaby wrote: > > s/mutex_lock/mutex_unlock/ on 2 fail paths in snd_pcm_oss_proc_write. > Probably a typo, lock should be unlocked when leaving the function. > > Signed-off-by: Jiri Slaby <jirislaby@...il.com> Thanks, applied both patches now. Takashi > Cc: Jaroslav Kysela <perex@...ex.cz> > Cc: Takashi Iwai <tiwai@...e.de> > --- > sound/core/oss/pcm_oss.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c > index ddf83c8..dda000b 100644 > --- a/sound/core/oss/pcm_oss.c > +++ b/sound/core/oss/pcm_oss.c > @@ -2887,7 +2887,7 @@ static void snd_pcm_oss_proc_write(struct snd_info_entry *entry, > setup = kmalloc(sizeof(*setup), GFP_KERNEL); > if (! setup) { > buffer->error = -ENOMEM; > - mutex_lock(&pstr->oss.setup_mutex); > + mutex_unlock(&pstr->oss.setup_mutex); > return; > } > if (pstr->oss.setup_list == NULL) > @@ -2901,7 +2901,7 @@ static void snd_pcm_oss_proc_write(struct snd_info_entry *entry, > if (! template.task_name) { > kfree(setup); > buffer->error = -ENOMEM; > - mutex_lock(&pstr->oss.setup_mutex); > + mutex_unlock(&pstr->oss.setup_mutex); > return; > } > } > -- > 1.6.2 > caught by stanse > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists