linux-kernel - Re: [Tux3] Tux3 report: Tux3 Git tree available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Mar 2009 03:25:09 -0700
From:	Daniel Phillips <phillips@...nq.net>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, tux3@...3.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Tux3] Tux3 report: Tux3 Git tree available

On Thursday 12 March 2009, Sam Ravnborg wrote:
> > 
> > > > > - What's "L"?
> > > > > 
> > > > > 		printf("%Lx-", (L)begin);
> > > > 
> > > > A very handy way of working around 32/64 bit format string issues.  We
> > > > just cast all the messy cases to (long long), aka (L).  All other
> > > > solutions to this messy problem are worse in my opinion, but whatever
> > > > the ruling is, is what we will do.  This is used heavily in tracing and
> > > > dumping code, which can all be turned off with ifdefs, so it doesn't
> > > > affect production kernel text.
> > > 
> > > What format string issues are we talking about here?
> > > 
> > > See, a number of them will be fixed real soon now (geologically
> > > speaking) when various 64-bit architectures switch their s64/u64
> > > implementation from `long' to `long long'.
> > 
> > Ah, that would be helpful.  But not done yet?  How long until it
> > happens, and does it make sense to wait, so we can reduce the number
> > of problems cases?  And... will it be all 64 bit arches or just some?
> > Because this issue isn't solved if it isn't fixed for all arches.
> 
> Most if not all will hit mainline during coming merge window.
> When an arch changes u64 becomes unsigned long long.
> 
> It is considered a 'must have' for 64 bit archs these days so
> do not workaround it.

OK, well a mindless edit of (L) to (long long) isn't a workaround, just
a reshuffle.  Then maybe when the 64 bit changes land in a month or two
we can lose most or all of those ugly things.

Regards,

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/