linux-kernel - Re: Off-by-one in both LIBATA and IDE drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9CEE6A51B15649D3ABEBD9BE0241A345@DIAMOND8600>
Date:	Thu, 12 Mar 2009 20:20:48 +0900
From:	"Norman Diamond" <n0diamond@...oo.co.jp>
To:	"Jim Paris" <jim@...n.com>
Cc:	<linux-kernel@...r.kernel.org>, <linux-ide@...r.kernel.org>,
	"Robert Hancock" <hancockrwd@...il.com>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Sergei Shtylyov" <sshtylyov@...mvista.com>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>,
	"Norman Diamond" <n0diamond@...oo.co.jp>
Subject: Re: Off-by-one in both LIBATA and IDE drivers

Jim Paris wrote:
> Norman Diamond wrote:
>>
>> It looks like both LIBATA and the old IDE drivers have an off-by-one 
>> error in deciding whether to use READ SECTOR(S) instead of READ SECTOR(S) 
>> EXT.
>
> This was fixed here:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=97b697a11b07e2ebfa69c488132596cc5eb24119

I'm still having trouble after applying the same patch to 2.6.24.3 (applying 
it three times in order to build Slax).  But now I wonder if it's no longer 
the fault of drivers.

Does hdparm construct its own taskfiles for ATA and SATA in order to produce 
an error trying to read sector number 0x0fffffff even after I patched the 
kernel?

If dd works then did I adequately patch the kernel?

Meanwhile I think the kernel needs more patches than ata.h.
(1)  libata-core.c contains a suspicious expression 1UL << 28.
(2)  sata_inic162x.c contains a suspicious expression 1 << 28. 

--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/