linux-kernel - [PATCH] remove pointless strdup() on arguments passed to new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <49B90DFE.76E4.0078.0@novell.com>
Date:	Thu, 12 Mar 2009 12:28:30 +0000
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	<sam@...nborg.org>
Cc:	<linux-kernel@...r.kernel.org>
Subject: [PATCH] remove pointless strdup() on arguments passed to
	 new_module()

new_module() itself already calls strdup() on its modname parameter.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>

---
 scripts/mod/modpost.c |   4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.29-rc7/scripts/mod/modpost.c	2008-12-25 00:26:37.000000000 +0100
+++ 2.6.29-rc7-module-modpost/scripts/mod/modpost.c	2009-01-20 09:47:23.000000000 +0100
@@ -1910,7 +1910,7 @@ static void read_dump(const char *fname,
 		if (!mod) {
 			if (is_vmlinux(modname))
 				have_vmlinux = 1;
-			mod = new_module(NOFAIL(strdup(modname)));
+			mod = new_module(modname);
 			mod->skip = 1;
 		}
 		s = sym_add_exported(symname, mod, export_no(export));
@@ -1994,7 +1994,7 @@ static void read_markers(const char *fna
 
 		mod = find_module(modname);
 		if (!mod) {
-			mod = new_module(NOFAIL(strdup(modname)));
+			mod = new_module(modname);
 			mod->skip = 1;
 		}
 		if (is_vmlinux(modname)) {



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/