[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090312150603.1aecdba9@hyperion.delvare>
Date: Thu, 12 Mar 2009 15:06:03 +0100
From: Jean Delvare <khali@...ux-fr.org>
To: Mauro Carvalho Chehab <mchehab@...radead.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: feature-removal-schedule.txt for some I2C functions
Hi Mauro,
On Thu, 12 Mar 2009 10:26:17 -0300, Mauro Carvalho Chehab wrote:
> Hi Jean,
>
> On your entry at Documentation/feature-removal-schedule.txt:
>
> What: i2c_attach_client(), i2c_detach_client(), i2c_driver->detach_client()
> When: 2.6.29 (ideally) or 2.6.30 (more likely)
> Why: Deprecated by the new (standard) device driver binding model. Use
> i2c_driver->probe() and ->remove() instead.
> Who: Jean Delvare <khali@...ux-fr.org>
>
> You forgot to add a check entry, like:
> Check: i2c_attach_client i2c_detach_client i2c_driver->detach_client
>
> The check entry is used by checkpatch.pl to warn about the usage of a legacy function.
>
> Please fix it, since me and others rely on this tool to discover about the
> usage of legacy functions.
Thanks for the tip, I didn't know about this. Is there some
documentation about the Check: entry format? If checkpatch.pl simply
matches the strings then i2c_driver->detach_client is never going to
match, so there's no point in adding it.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists