linux-kernel - Re: [PATCH] 8139cp: allow to set mac address on running device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090312181121.79e297a2@brian.englab.brq.redhat.com>
Date:	Thu, 12 Mar 2009 18:11:21 +0100
From:	Michal Schmidt <mschmidt@...hat.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	linux-kernel@...r.kernel.org, ivecera@...hat.com,
	jgarzik@...ox.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] 8139cp: allow to set mac address on running device

On Thu, 12 Mar 2009 17:27:31 +0100
Jiri Pirko <jpirko@...hat.com> wrote:

> +	cpw32_f(MAC0 + 0, le32_to_cpu (*(__le32 *) (dev->dev_addr +
> 0)));
> +	cpw32_f(MAC0 + 4, le32_to_cpu (*(__le32 *) (dev->dev_addr +
> 4)));

You're writing to the card, so using *_to_cpu looks suspicious.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/