linux-kernel - Re: [PATCH] tracing/core: bring back raw trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903121350490.3062@gandalf.stny.rr.com>
Date:	Thu, 12 Mar 2009 13:51:30 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing/core: bring back raw trace_printk for dynamic
 formats strings


On Thu, 12 Mar 2009, Frederic Weisbecker wrote:

> Impact: fix callsites with dynamic format strings
> 
> Since its new binary implementation, trace_printk() internally uses static
> containers for the format strings on each callsites.
> But the value is assigned once at build time, which means that it can't take
> dynamic formats.
> 
> So this patch unearthes the raw trace_printk implementation for the callers
> that will need trace_printk to be able to carry these dynamic format strings.
> The trace_printk() macro will use the appropriate implementation for each
> callsite.
> Most of the time however, the binary implementation will still be used.
> 
> The other impact of this patch is that mmiotrace_printk() will use the old
> implementation because it calls the low level trace_vprintk and we can't guess
> here whether the format passed in it is dynamic or not.
> 
> Some parts of this patch have been written by Steven Rostedt (most notably the
> part that chooses the appropriate implementation for each callsites).
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>

Thanks Frederic!

Ingo, I'm going to pull this in my tree, since I have some patches 
dependent on it.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/