| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Mar 2009 15:03:36 -0500 From: Rob Landley <rob@...dley.net> To: Sam Ravnborg <sam@...nborg.org> Cc: linux-kernel@...r.kernel.org, dwmw2@...radead.org, linux-next@...r.kernel.org Subject: Re: make headers_install broken for ARCH=m68k in 2.6.29-rc7. On Thursday 12 March 2009 04:58:54 Sam Ravnborg wrote: > On Thu, Mar 12, 2009 at 04:37:03AM -0500, Rob Landley wrote: > > So I'm doing this: > > > > make ARCH=m68k headers_install INSTALL_HDR_PATH=walrus > > > > And it doesn't install unistd_mm.h which is included from asm/unistd.h. > > (The file is there in arch/m68k/include/asm/unistd_mm.h, it just doesn't > > get installed. So any code that #includes <asm/unistd.h> results in a > > file not found error for the other one, which is essentially just a > > wrapper.) > > > > I don't understand what the code's currently doing here well enough to > > fix it, specifically where does this file list come from? The file > > arch/m68k/include/asm/Kbuild is adding "cachectl.h" to header-y, but > > there are 31 files getting installed from that directory and only one in > > there. > > Kbuild contains the following: > > include include/asm-generic/Kbuild.asm > header-y += cachectl.h > > And if you look up the content of "include/asm-generic/Kbuild.asm" Ah, I was grepping for header-y and this is full of unifdef-y, so I didn't look too closely at this file. (I did glance at it, but the first thing I saw was "errno.h" and there's an errno.h in the include/asm-generic directory, so I thought it was describing itself. I presume it tries the arch one first and falls back to asm-generic if it's not there?) > you will realize that this is a list of all the "always to be exported > headers" from any arch - so the list is consolidated in asm-generic. > > The fix for m68k is to eiter: > 1) unify unistd.h so we get rid of the _no.h and _mm.h variants > 2) or add the _no.h and _mm.h files to Kbuild. > > I recall that someone already did 1) and this is pending in m68k.git. I hope this patch can be cherry picked so 2.6.29 doesn't ship broken for m68k. > You could look in -next - I think it is fixed there. Is there any way to download that as a tarball? No mention of it on the main kernel.org page. I checked http://www.kernel.org/pub/linux/kernel/testing/ http://www.kernel.org/pub/linux/kernel/v2.6/snapshots/ http://www.kernel.org/pub/linux/kernel/v2.6/testing/ and a few other places. No dice. Googling for "linux-next" finds a blog entry and a few links to discussion on kernel trap, but no link to where to _get_ it in any of those... Googling for "linux-next tarball" finds... http://lkml.org/lkml/2008/2/21/449 which has a dead link. And by the third google hit we're into discussion of the 2.4.18 kernel and hppa platform. Not promising. Seems kind of silly to let git grind away downloading hundreds of megabytes of history that'll just get wiped (especially since that tree gets regenerated nightly), but oh well. Assuming that kernel development is git-centric enough that a tarball version of a regenerated nightly resource just never seemed important, said git repository would be on git.kernel.org, but where... linux/kernel/git/eranian/linux-next.git isn't it... linux/kernel/git/mchehab/linux-next.git isn't it... Ah, linux/kernel/git/sfr/linux-next.git is the one I'm looking for. Now where was the magic incantation to translate from the web url to a git url... Ah, at the top of the page. time git clone \ git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git Wander off to read the big long http://lkml.org/lkml/2008/2/11/512 thread google pulled up earlier, wander back when bored, the download is at 43% averaging about 350k/second... Go read some more... Am I doing something wrong here? Other people can't possibly find this A) this tedious, B) this undocumented. And it finished: > real 22m38.058s > user 2m27.257s > sys 0m34.258s And, yes, I can confirm the m68k include/asm/unistd.h from linux-next actually has contents, thanks to commit 646652bded41f4c3bd375b4e03a25b42da93f40b Anyway, here's hoping the fix makes it into 2.6.29. > Sam Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists