linux-kernel - Re: [PATCH] VM, x86, PAT: Change implementation of is_linear_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Mar 2009 21:30:21 +0100
From:	Frans Pop <elendil@...net.nl>
To:	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
Cc:	"mingo@...e.hu" <mingo@...e.hu>,
	"thellstrom@...are.com" <thellstrom@...are.com>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	Nick Piggin <npiggin@...e.de>,
	"ebiederm@...ssion.com" <ebiederm@...ssion.com>
Subject: Re: [PATCH] VM, x86, PAT: Change implementation of is_linear_pfn_mapping

On Thursday 12 March 2009, Pallipadi, Venkatesh wrote:
> OK, Looking more at the code, I now understand how the patch from
> yday resulted in the oops you saw. Here goes my nth attempt at solving
> this problem. Can you please test this patch.

System has been running stable for almost an hour now with pat enabled, so 
it looks like the problem is solved.

FYI, with early .29 RCs I had the following when running VirtualBox:
kernel: WARNING: at arch/x86/mm/pat.c:620 reserve_pfn_range+0x5b/0x26d()

After be03d9e80220 (which probably fixed that) VirtualBox could no longer 
be loaded at all with pat enabled, but with this patch added VirtualBox 
runs perfectly again.

Thanks Venki.

> Use of vma->vm_pgoff to identify the pfnmaps that are fully
> mapped at mmap time is broken. vm_pgoff is set by generic mmap
> code even for cases where drivers are setting up the mappings
> at the fault time.
>
> The problem was originally reported here.
> http://marc.info/?l=linux-kernel&m=123383810628583&w=2
>
> Change is_linear_pfn_mapping logic to overload VM_INSERTPAGE
> flag along with VM_PFNMAP to mean full PFNMAP setup at mmap
> time.
>
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
> Signed-off-by: Suresh Siddha <suresh.b.siddha>@intel.com>

Tested-by: Frans Pop <elendil@...net.nl>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/