linux-kernel - Re: [PATCH 10/7] mmc_spi: fix bug introduced in patch 3/7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Mar 2009 12:57:00 -0800
From:	David Brownell <david-b@...bell.net>
To:	Wolfgang Mües <wolfgang.mues@...rswald.de>
Cc:	Pierre Ossman <drzeus@...eus.cx>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Matt Fleming" <matt@...sole-pimps.org>,
	"Mike Frysinger" <vapier.adi@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/7] mmc_spi: fix bug introduced in patch 3/7

On Thursday 12 March 2009, Wolfgang Mües wrote:
> From: Wolfgang Muees <wolfgang.mues@...rswald.de>
> 
> o Fix bug introduced in patch 3/7.
>   The first 3 bits of the data response may be undefined;
>   assuming that these bits are always 1 lead to unreliable
>   transmission.
> 
> Signed-off-by: Wolfgang Muees <wolfgang.mues@...rswald.de>

Could you just send an updated version of #3?  Addressing
both this issue and the previous "comment is confusing" one.
I could ack such an update.


> 
> ---
> 
> diff -uprN 2_6_29_rc7_patch9_speedup/drivers/mmc/host/mmc_spi.c 2_6_29_rc7_patch10_bugfix_of_patch3/drivers/mmc/host/mmc_spi.c
> --- 2_6_29_rc7_patch9_speedup/drivers/mmc/host/mmc_spi.c	2009-03-12 14:35:27.000000000 +0100
> +++ 2_6_29_rc7_patch10_bugfix_of_patch3/drivers/mmc/host/mmc_spi.c	2009-03-12 14:40:03.000000000 +0100
> @@ -725,6 +725,9 @@ mmc_spi_writeblock(struct mmc_spi_host *
>  	pattern |= scratch->status[2] << 8;
>  	pattern |= scratch->status[3];
>  
> +	/* First 3 bit of pattern are undefined */
> +	pattern |= 0xE0000000;
> +
>  	/* left-adjust to leading 0 bit */
>  	while (pattern & 0x80000000)
>  		pattern <<= 1;
> 
> ---
> regards
> 
> i. A. Wolfgang Mües
> -- 
> Auerswald GmbH & Co. KG
> Hardware Development
> Telefon: +49 (0)5306 9219 0
> Telefax: +49 (0)5306 9219 94 
> E-Mail: Wolfgang.Mues@...rswald.de
> Web: http://www.auerswald.de
>  
> --------------------------------------------------------------
> Auerswald GmbH & Co. KG, Vor den Grashöfen 1, 38162 Cremlingen
> Registriert beim AG Braunschweig HRA 13289
> p.h.G Auerswald Geschäftsführungsges. mbH
> Registriert beim AG Braunschweig HRB 7463
> Geschäftsführer: Dipl-Ing. Gerhard Auerswald
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/