| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200903111945.22597.david-b@pacbell.net> Date: Wed, 11 Mar 2009 18:45:22 -0800 From: David Brownell <david-b@...bell.net> To: Wolfgang Mües <wolfgang.mues@...rswald.de> Cc: Pierre Ossman <drzeus@...eus.cx>, "Andrew Morton" <akpm@...ux-foundation.org>, "Matt Fleming" <matt@...sole-pimps.org>, "Mike Frysinger" <vapier.adi@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/7] mmc_spi: convert timeout handling to jiffies and avoid busy waiting On Wednesday 11 March 2009, Wolfgang Mües wrote: > o SD/MMC card timeouts can be very high. So avoid busy-waiting, > using the scheduler. Calculate all timeouts in jiffies units, > because this will give us the correct sign when to involve > the scheduler. Of these patches, this is the one that bothers me the most. First, earlier versions used jiffies ... but switching to ktime sped things up. (I forget the details by now.) So it's odd to think that switching again could improve things. At any rate, if that's worth doing it's worth having as a separate patch. Second, as someone previously pointed out, there's a comment there about switching to sleep() calls ... did you explore just kicking in schedule_hrtimeout() or somesuch, right at that point? Heck, just calling schedule() would cut the busy-wait overhead... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists