linux-kernel - Re: [PATCH 3/4] tracing: move binary buffers into per cpu directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090312221634.407c82ad.akpm@linux-foundation.org>
Date:	Thu, 12 Mar 2009 22:16:34 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 3/4] tracing: move binary buffers into per cpu directory

On Fri, 13 Mar 2009 01:04:49 -0400 Steven Rostedt <rostedt@...dmis.org> wrote:

>  	if (!entry)
>  		pr_warning("Could not create debugfs 'trace' entry\n");
> +
> +	entry = debugfs_create_file("trace_pipe_raw", 0444, d_cpu,
> +				    (void *) cpu, &tracing_buffers_fops);
> +	if (!entry)
> +		pr_warning("Could not create debugfs 'trace_pipe_raw' entry\n");

Maybe we should just do the warning in debugfs_create_file().  It's hard to
think of a scenario where we wouldn't want this failure to be reported.

If there is such a scenario then debugfs_create_file_nowarn() beckons.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/