linux-kernel - Re: [PATCH 4/4] softirq: no need to have SOFTIRQ in softirq name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1236922811.2553.16.camel@ht.satnam>
Date:	Fri, 13 Mar 2009 11:10:11 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 4/4] softirq: no need to have SOFTIRQ in softirq name

On Fri, 2009-03-13 at 01:04 -0400, Steven Rostedt wrote:
> plain text document attachment
> (0004-softirq-no-need-to-have-SOFTIRQ-in-softirq-name.patch)
> From: Steven Rostedt <srostedt@...hat.com>
> 
> Impact: clean up
> 
> It is redundant to have 'SOFTIRQ' in the softirq names.
> 
> Reported-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Steven Rostedt <srostedt@...hat.com>
> ---
>  kernel/softirq.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index a5e8123..65ff3e3 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -55,9 +55,8 @@ static struct softirq_action softirq_vec[NR_SOFTIRQS] __cacheline_aligned_in_smp
>  static DEFINE_PER_CPU(struct task_struct *, ksoftirqd);
>  
>  char *softirq_to_name[NR_SOFTIRQS] = {
> -	"HI_SOFTIRQ", "TIMER_SOFTIRQ", "NET_TX_SOFTIRQ", "NET_RX_SOFTIRQ",
> -	"BLOCK_SOFTIRQ", "TASKLET_SOFTIRQ", "SCHED_SOFTIRQ", "HRTIMER_SOFTIRQ",
> -	"RCU_SOFTIRQ"
> +	"HI", "TIMER", "NET_TX", "NET_RX", "BLOCK",
> +	"TASKLET", "SCHED", "HRTIMER",	"RCU"
>  };
>  

This will look more better:

+	"HI",		"TIMER",	"NET_TX",
+	"NET_RX",	"BLOCK",	"TASKLET",
+	"SCHED",	"HRTIMER",	"RCU"

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/