linux-kernel - Re: [PATCH] dmaengine: sh: Add support DMA-Engine driver for DMA of SuperH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Mar 2009 10:02:41 +0900
From:	Nobuhiro Iwamatsu <iwamatsu.nobuhiro@...esas.com>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	Linux-sh <linux-sh@...r.kernel.org>, linux-kernel@...r.kernel.org,
	maciej.sosnowski@...el.com, dan.j.williams@...el.com,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH] dmaengine: sh: Add support DMA-Engine driver for DMA of
 SuperH

Hi, Matt.

Thank you for your review.

Matt Fleming wrote:
> On Thu, Mar 12, 2009 at 03:44:55PM +0900, Nobuhiro Iwamatsu wrote:
>> This supports DMA-Engine driver for DMA of SuperH.
>> This supported all DMA channels, and it was tested in SH7722/SH7780.
>> This can not use with SH DMA API and can control this in Kconfig.
>>
> 
> I was working on support for this, but fortunately for me you beat me
> to a finished implementation ;-)
> 
> The code looks good to me. Just a few (very very) minor nits.
> 
> Reviewed-by: Matt Fleming <matt@...sole-pimps.org>
> 
> [...]
> 
>> +/* for dma engine */
>> +/* mode */
>> +#define SHDMA_MIX_IRQ	(1 << 1)
> 
> The proper multi-line kernel comment style is
> 
> 	/*
> 	 *
> 	 */
> 
> though this comment can all fit on one line.
> 
OK, I fix it.
>> +
>> +static void dmae_init(struct sh_dmae_chan *sh_chan)
>> +{
>> +	u32 chcr = RS_DEFAULT; /* default is DUAL mode */
>> +	sh_dmae_writel(sh_chan, chcr, CHCR);
>> +}
>> +
>> +/*
>> + * Reset DMA controler
> 
> controler -> controller
> 
Oops, thank you.

I fix your check point and resend patch.

Best regards,
  Nobuhiro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/