linux-kernel - Re: [tip:core/ipi] generic-ipi: eliminate spurious pointless WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090313093109.GE2571@elte.hu>
Date:	Fri, 13 Mar 2009 10:31:09 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	jbeulich@...ell.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/ipi] generic-ipi: eliminate spurious pointless
	WARN_ON()s


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Fri, 2009-03-13 at 01:39 +0000, Jan Beulich wrote:
> > Commit-ID:  6a09dfa870ba0ed21b1124539968a36b42660661
> > Gitweb:     http://git.kernel.org/tip/6a09dfa870ba0ed21b1124539968a36b42660661
> > Author:     Jan Beulich <jbeulich@...ell.com>
> > AuthorDate: Thu, 12 Mar 2009 13:21:50 +0000
> > Commit:     Ingo Molnar <mingo@...e.hu>
> > CommitDate: Fri, 13 Mar 2009 02:14:41 +0100
> > 
> > generic-ipi: eliminate spurious pointless WARN_ON()s
> > 
> > Namely during early boot, the panic() or BUG() paths may end up in
> > smp_call_function_*() with just a single online CPU. In that situation
> > the warnings generated are not only meaningless, but also result in
> > relevant output being cluttered.
> > 
> > Therefore, defer the WARN_ON() checks until after the (unaffected from
> > the problem that is being attempted to be detected here) cases have
> > been handled.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> > LKML-Reference: <49B91A7E.76E4.0078.0@...ell.com>
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> I don't really like this,.. it moves the WARN_ON to weird 
> locations without an explanatory comment.

ok, i've reverted it for now.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/