linux-kernel - Re: [tip:core/futexes] futex: remove the pointer math from double_unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49BA75CF.3040501@us.ibm.com>
Date:	Fri, 13 Mar 2009 08:03:43 -0700
From:	Darren Hart <dvhltc@...ibm.com>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...e.hu
CC:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/futexes] futex: remove the pointer math from double_unlock_hb,
 fix

Ingo Molnar wrote:
> Commit-ID:  88f502fedba82eff252b6420e8b8328e4ae25c67
> Gitweb:     http://git.kernel.org/tip/88f502fedba82eff252b6420e8b8328e4ae25c67
> Author:     Ingo Molnar <mingo@...e.hu>
> AuthorDate: Fri, 13 Mar 2009 10:32:07 +0100
> Commit:     Ingo Molnar <mingo@...e.hu>
> CommitDate: Fri, 13 Mar 2009 10:32:07 +0100
> 
> futex: remove the pointer math from double_unlock_hb, fix
> 
> Impact: fix double unlock crash
> 
> Thomas Gleixner noticed that the simplified double_unlock_hb()
> became ... too unsophisticated: in the hb1 == hb2 case it will
> do a double unlock.

Gah.  Thanks for catching it.

> 
> Reported-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Darren Hart <dvhltc@...ibm.com>
> LKML-Reference: <20090312221118.11146.68610.stgit@...n>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Acked-by: Darren Hart <dvhltc@...ibm.com>

> 
> 
> ---
>  kernel/futex.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/futex.c b/kernel/futex.c
> index 2331b73..6b50a02 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -659,7 +659,8 @@ static inline void
>  double_unlock_hb(struct futex_hash_bucket *hb1, struct futex_hash_bucket *hb2)
>  {
>  	spin_unlock(&hb1->lock);
> -	spin_unlock(&hb2->lock);
> +	if (hb1 != hb2)
> +		spin_unlock(&hb2->lock);
>  }
> 
>  /*


-- 
Darren Hart
IBM Linux Technology Center
Real-Time Linux Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/