linux-kernel - Re: [PATCH, RFC] sysfs: only allow one scheduled removal callback per kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090313180829.GC5335@ldl.fc.hp.com>
Date:	Fri, 13 Mar 2009 12:08:29 -0600
From:	Alex Chiang <achiang@...com>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
Cc:	Greg KH <gregkh@...e.de>, Tejun Heo <tj@...nel.org>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Ingo Molnar <mingo@...e.hu>, jbarnes@...tuousgeek.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH, RFC] sysfs: only allow one scheduled removal callback
	per kobj

* Cornelia Huck <cornelia.huck@...ibm.com>:
> On Thu, 12 Mar 2009 16:02:31 -0600,
> Alex Chiang <achiang@...com> wrote:
> > 
> > Cornelia, I understand your earlier point about a smaller patch
> > in the caller, but I think pushing the code down into the
> > infrastructure is the right thing to do. 
> 
> OK, I don't have further objections.

Thanks.

> > Also, I wasn't brave
> > enough to patch your ccwgroup_ungroup_store(), but I think you
> > won't need the gdev->onoff stuff anymore in that code path.
> 
> We still need it to prevent online/offline vs. ungroup races.
> 
> While device_schedule_callback() should not be able to return -EAGAIN
> on us, I'll sleep better if you could add the following snippet to your
> patch:

Added and resent to Greg.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/