linux-kernel - Re: [PATCH V3] kallsyms, tracing: output more proper symbol name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49BAC340.5030100@grupopie.com>
Date:	Fri, 13 Mar 2009 20:34:08 +0000
From:	Paulo Marques <pmarques@...popie.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Sam Ravnborg <sam@...nborg.org>, laijs@...fujitsu.com,
	mingo@...e.hu, srostedt@...hat.com, fweisbec@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] kallsyms, tracing: output more proper symbol name

Andrew Morton wrote:
> On Fri, 13 Mar 2009 20:40:13 +0100
> Sam Ravnborg <sam@...nborg.org> wrote:
> 
>>> This patch puts symbols like "__irqentry_text_start" to the second
>>> aliased symbols. And a more proper symbol name becomes the first.
>>>
>>> Aliased symbols mostly come from linker script. The solution is
>>> guessing "is this symbol defined in linker script", the symbols
>>> defined in linker script will not become the first aliased symbol.
>>>
>>> And if symbols are found to be equal in this "linker script provided"
>>> criteria, symbols are sorted by the number of prefix underscores.
>>>
>>> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
>> Looks good to me.
>>
>> Acked-by: Sam Ravnborg <sam@...nborg.org>
> 
> So... do we need this in 2.6.29?

IMHO, no. I think the way the kernel handles aliased symbols hasn't
changed in a very long time so one more release shouldn't make a big
difference.

Even if the risk of the patch breaking something is small, taking that
chance for such a small gain this late in the 2.6.29 cycle is just not
worth it.

-- 
Paulo Marques - www.grupopie.com

"You're just jealous because the voices only talk to me."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/