linux-kernel - Re: [PROBLEM]: potential unaligned memory access in drivers/usb/gadget/rndis.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090313.135216.19807120.davem@davemloft.net>
Date:	Fri, 13 Mar 2009 13:52:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	akpm@...ux-foundation.org, yann.poupet@...e.fr,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PROBLEM]: potential unaligned memory access in
 drivers/usb/gadget/rndis.c

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Thu, 12 Mar 2009 16:51:37 -0700

> On Wed, 2009-03-11 at 23:51 -0700, Andrew Morton wrote:
> 
> > Maybe the below fixed this?  afacit it is queued for 2.6.30 in the
> > net-next tree: 
> > 
> > commit 35c26c2cf6a6a2d1c48add732d8ba002bd90784c
> > Author:     Harvey Harrison <harvey.harrison@...il.com>
> > AuthorDate: Sat Feb 14 22:56:56 2009 -0800
> > Commit:     David S. Miller <davem@...emloft.net>
> > CommitDate: Sat Feb 14 22:56:56 2009 -0800
> > 
> >     rndis: remove private wrapper of __constant_cpu_to_le32
> >     
> >     Use cpu_to_le32 directly as it handles constant folding now, replace direct
> >     uses of __constant_cpu_to_{endian} as well.
> >     
> >     Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> >     Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>
> >     Signed-off-by: David S. Miller <davem@...emloft.net>
> > 
> 
> Doubtful, this patch should be a no-op, any alignment problems that existed
> before will still be there.

Agreed, that patch won't do anything wrt. the alignment issue being
reported here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/