linux-kernel - Re: [tip:tracing/syscalls] x86: entry_32.S fix compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Mar 2009 13:59:29 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	jaswinderrajput@...il.com, fweisbec@...il.com, hpa@...nel.org,
	rostedt@...dmis.org, tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:tracing/syscalls] x86: entry_32.S fix compile warnings -
 fix work mask bit width

On Sat, 2009-03-14 at 11:13 +0300, Cyrill Gorcunov wrote:
> [Jaswinder Singh Rajput - Sat, Mar 14, 2009 at 07:18:32AM +0000]
> | Commit-ID:  95baa1a17ff80183317d815189fe1f12fdb653bc
> | Gitweb:     http://git.kernel.org/tip/95baa1a17ff80183317d815189fe1f12fdb653bc
> | Author:     Jaswinder Singh Rajput <jaswinder@...nel.org>
> | AuthorDate: Sat, 14 Mar 2009 12:08:13 +0530
> | Commit:     Ingo Molnar <mingo@...e.hu>
> | CommitDate: Sat, 14 Mar 2009 08:16:01 +0100
> | 
> | x86: entry_32.S fix compile warnings - fix work mask bit width
> | 
> | Fix:
> | 
> |  arch/x86/kernel/entry_32.S:446: Warning: 00000000080001d1 shortened to 00000000000001d1
> |  arch/x86/kernel/entry_32.S:457: Warning: 000000000800feff shortened to 000000000000feff
> |  arch/x86/kernel/entry_32.S:527: Warning: 00000000080001d1 shortened to 00000000000001d1
> |  arch/x86/kernel/entry_32.S:541: Warning: 000000000800feff shortened to 000000000000feff
> |  arch/x86/kernel/entry_32.S:676: Warning: 0000000008000091 shortened to 0000000000000091
> | 
> | TIF_SYSCALL_FTRACE is 0x08000000 and until now we checked the
> | first 16 bits of the work mask - bit 27 falls outside of that.
> | 
> | Update the entry_32.S code to check the full 32-bit mask.
> | 
> | Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> | Cc: Frederic Weisbecker <fweisbec@...il.com>
> | Cc: Steven Rostedt <rostedt@...dmis.org>
> | Cc: "H. Peter Anvin" <hpa@...nel.org>
> | LKML-Reference: <1237012693.18733.3.camel@...satnam>
> | Signed-off-by: Ingo Molnar <mingo@...e.hu>
> | 
> | 
> | ---
> |  arch/x86/kernel/entry_32.S |   18 ++++++++----------
> |  1 files changed, 8 insertions(+), 10 deletions(-)
> | 
> ...  
> |  sysexit_audit:
> | -	testw $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %cx
> | +	testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %cx
> 							^^^^^
> Better to point ecx here? :)
> 

Thanks Cyrill :-)

Subject: [PATCH] x86: entry_32.S fix compile warnings - fix work mask bit width - v2

Replace cx with ecx

Reported-by: Cyrill Gorcunov <gorcunov@...il.com>
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
---
 arch/x86/kernel/entry_32.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 82cf555..c929add 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -484,7 +484,7 @@ sysenter_audit:
 	jmp sysenter_do_call
 
 sysexit_audit:
-	testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %cx
+	testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %ecx
 	jne syscall_exit_work
 	TRACE_IRQS_ON
 	ENABLE_INTERRUPTS(CLBR_ANY)
-- 
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/