linux-kernel - Re: [PATCH -tip] x86: trampoline.c cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0903141718120.29264@localhost.localdomain>
Date:	Sat, 14 Mar 2009 17:20:11 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
cc:	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: trampoline.c cleanup

On Sat, 14 Mar 2009, Jaswinder Singh Rajput wrote:

> Subject: [PATCH] x86: trampoline.c cleanup
> 
> Impact: cleanup
> 
>  - fix style problems

Err. This patch is a style problem itself.
 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  arch/x86/kernel/trampoline.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/trampoline.c b/arch/x86/kernel/trampoline.c
> index 808031a..e3b1f2e 100644
> --- a/arch/x86/kernel/trampoline.c
> +++ b/arch/x86/kernel/trampoline.c
> @@ -15,7 +15,7 @@ void __init reserve_trampoline_memory(void)
>  	 * trampoline before removing it. (see the GDT stuff)
>  	 */
>  	reserve_early(PAGE_SIZE, PAGE_SIZE + PAGE_SIZE, "EX TRAMPOLINE");
> -#endif
> +#endif /* CONFIG_X86_32 */

There is no need for this useless comment. The #ifdef is 5 lines
above. Such comments are only helpful in large nested sections.

>  	/* Has to be in very low memory so we can execute real-mode AP code. */
>  	reserve_early(TRAMPOLINE_BASE, TRAMPOLINE_BASE + TRAMPOLINE_SIZE,
>  			"TRAMPOLINE");
> @@ -29,5 +29,6 @@ void __init reserve_trampoline_memory(void)
>  unsigned long setup_trampoline(void)
>  {
>  	memcpy(trampoline_base, trampoline_data, TRAMPOLINE_SIZE);
> +
>  	return virt_to_phys(trampoline_base);

What's the purpose of this ?

Can we please apply some common sense and not just run down a
checklist and modify files for no value.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/