linux-kernel - Re: [PATCH 1/1] Char: moxa, fix refcounting in moxa_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 15 Mar 2009 12:52:00 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Jan Kasprzak <kas@...muni.cz>
Subject: Re: [PATCH 1/1] Char: moxa, fix refcounting in moxa_poll_port

Restoring CCs.

On 15.3.2009 11:55, Alan Cox wrote:
> On Sun, 15 Mar 2009 10:36:08 +0100
> Jiri Slaby<jirislaby@...il.com>  wrote:
>
>> There is missing tty_kref_put on some paths in moxa_poll_port,
>> although the reference is always taken. Fix it.
>>
>> Signed-off-by: Jiri Slaby<jirislaby@...il.com>
>> Reported-by: Jan 'Yenya' Kasprzak<kas@...muni.cz>
>> Cc: Alan Cox<alan@...rguk.ukuu.org.uk>
>
> Acked-by: Alan Cox<alan@...rguk.ukuu.org.uk>

BTW the same sha, the change in isicom_shutdown_port doesn't seem to be 
quite right too. Well, the change itself is, but not in the code 
context. The tty is used even after tty_port_tty_set(NULL). This is 
wrong, isn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/