linux-kernel - Re: [tip:core/printk] fix regression from "vsprintf: unify the format decoding layer for its 3 users"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 15 Mar 2009 15:54:54 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	torvalds@...ux-foundation.org, vegard.nossum@...il.com,
	jeremy@...p.org, tglx@...utronix.de, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/printk] fix regression from "vsprintf: unify the
	format decoding layer for its 3 users"

On Sat, Mar 14, 2009 at 11:39:47AM +0000, Vegard Nossum wrote:
> Commit-ID:  adf26f84a62b492e002d3b75af671f23ddd3be0a
> Gitweb:     http://git.kernel.org/tip/adf26f84a62b492e002d3b75af671f23ddd3be0a
> Author:     Vegard Nossum <vegard.nossum@...il.com>
> AuthorDate: Sat, 14 Mar 2009 12:08:50 +0100
> Commit:     Ingo Molnar <mingo@...e.hu>
> CommitDate: Sat, 14 Mar 2009 12:37:08 +0100
> 
> fix regression from "vsprintf: unify the format decoding layer for its 3 users"
> 
> Jeremy Fitzhardinge reported:
> 
> > Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf:
> > unify the format decoding layer for its 3 users", causes a
> > regression in xenbus which results in no devices getting
> > attached to a new domain.
> 
> %.*s is broken - fix it.
> 
> Reported-by: Jeremy Fitzhardinge <jeremy@...p.org>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> 
> ---
>  lib/vsprintf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index dc16743..708e505 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -843,7 +843,7 @@ precision:
>  				spec->precision = 0;
>  		} else if (*fmt == '*') {
>  			/* it's the next argument */
> -			spec->type = FORMAT_TYPE_WITDH;
> +			spec->type = FORMAT_TYPE_PRECISION;
>  			return ++fmt - start;
>  		}
>  	}

Thanks a lot for this patch!

Frederic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/