[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090315185519.GB19737@elte.hu>
Date:	Sun, 15 Mar 2009 19:55:19 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: print out in e820_update_range()
* Yinghai Lu <yinghai@...nel.org> wrote:
> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@...nel.org> wrote:
> > 
> >> Impact: to find crazy calling
> >>
> >> try to print out more info, to catch wrong calling
> > 
> > Could we detect incorrect parameters more directly as well, via 
> > a check and a panic()?
> 
> only valid checking seems to be 
> virt_to_phys(_text), virt_to_phys(_end)
> 
> 
> if (new_type == E820_RESERVED && start >= virt_to_phys(_text) && start <= virt_to_phys(_end)) 
> 	panic("try to update to e820 range for kernel to RESERVED!");
hm, seems a bit too specialized.
	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Powered by blists - more mailing lists
 
