linux-kernel - Re: [PATCH] Added driver for ISL29003 ambient light sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m34oxvfikh.fsf@lugabout.jhcloos.org>
Date:	Sun, 15 Mar 2009 01:41:58 -0400
From:	James Cloos <cloos@...loos.com>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Added driver for ISL29003 ambient light sensor

>>>>> "Daniel" == Daniel Mack <daniel@...aq.de> writes:

Trivial comment on the docs:

Daniel> +mode:
Daniel> +	0: diode1's current (unsigned 16bit) (default)
Daniel> +	1: diode1's current (unsigned 16bit)
Daniel> +	2: difference between diodes (l1 - l2, signed 15bit)

That has diode1 twice.  Should it, instead, be:

+mode:
+	0: diode1's current (unsigned 16bit) (default)
+	1: diode2's current (unsigned 16bit)
+	2: difference between diodes (l1 - l2, signed 15bit)

?

-JimC
-- 
James Cloos <cloos@...loos.com>         OpenPGP: 1024D/ED7DAEA6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/