linux-kernel - Re: [patch] twl4030-regulator: expose VPLL2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1237203815.6781.294.camel@vega.slimlogic.co.uk>
Date:	Mon, 16 Mar 2009 11:43:35 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	dbrownell@...rs.sourceforge.net,
	Samuel Ortiz <sameo@...nedhand.com>
Cc:	Mark Brown <broonie@...ena.org.uk>,
	OMAP <linux-omap@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [patch] twl4030-regulator: expose VPLL2

On Fri, 2009-03-13 at 17:54 -0700, David Brownell wrote:
> From: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> Add VPLL2 to the set of twl4030-family regulators exposed for
> use by various drivers.  It's commonly used to power the digital
> video outputs (e.g. LCD or DVI displays) on OMAP3 systems.
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
> ---
> Please apply to regulator-next and linux-omap ... I'll send
> some patches configuring various OMAP boards to use this.
> 
>  drivers/mfd/twl4030-core.c            |    2 --
>  drivers/regulator/twl4030-regulator.c |    2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -613,11 +613,9 @@ add_children(struct twl4030_platform_dat
>  
>  	/* maybe add LDOs that are omitted on cost-reduced parts */
>  	if (twl_has_regulator() && !(features & TPS_SUBSET)) {
> -		/*
>  		child = add_regulator(TWL4030_REG_VPLL2, pdata->vpll2);
>  		if (IS_ERR(child))
>  			return PTR_ERR(child);
> -		*/
>  
>  		child = add_regulator(TWL4030_REG_VMMC2, pdata->vmmc2);
>  		if (IS_ERR(child))
> --- a/drivers/regulator/twl4030-regulator.c
> +++ b/drivers/regulator/twl4030-regulator.c
> @@ -404,8 +404,8 @@ static struct twlreg_info twl4030_regs[]
>  	TWL_ADJUSTABLE_LDO(VMMC2, 0x2b, 6),
>  	/*
>  	TWL_ADJUSTABLE_LDO(VPLL1, 0x2f, 7),
> -	TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
>  	*/
> +	TWL_ADJUSTABLE_LDO(VPLL2, 0x33, 8),
>  	TWL_ADJUSTABLE_LDO(VSIM, 0x37, 9),
>  	TWL_ADJUSTABLE_LDO(VDAC, 0x3b, 10),
>  	/*
> 

Samuel, I'm fine putting this through regulator if its fine with you ?

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/