linux-kernel - Re: [Xen-devel] [PATCH 10/27] xen: make sure swiotlb allocation isphysically contigious

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <49BE627E.76E4.0078.0@novell.com>
Date:	Mon, 16 Mar 2009 13:30:22 +0000
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Jeremy Fitzhardinge" <jeremy@...p.org>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	"Jeremy Fitzhardinge" <jeremy.fitzhardinge@...rix.com>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	"David Airlie" <airlied@...ux.ie>,
	"Xen-devel" <xen-devel@...ts.xensource.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH 10/27] xen: make sure swiotlb
	 allocation isphysically contigious

>>> Jeremy Fitzhardinge <jeremy@...p.org> 13.03.09 17:59 >>>
> void * __init swiotlb_alloc_boot(size_t size, unsigned long nslabs)
> {
>-	return alloc_bootmem_low_pages(size);
>+	void *ret = alloc_bootmem_low_pages(size);
>+
>+	if (ret && xen_pv_domain())
>+		xen_swiotlb_fixup(ret, size, nslabs);
>+
>+	return ret;
> }
 
While on native using alloc_bootmem_low_pages() is a requirement here,
on Xen this should explicitly not be used, as we realized just a couple of
days ago: The way the bootmem allocator works, running out of space
below 4Gb is pretty easy on machines with lots of memory, and since the
swiotlb is a requirement for Dom0, the risk of allocation failures must be
kept as low as possible.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/