linux-kernel - RE: [patch 1/5] x86, bts: detect size of DS fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <928CFBE8E7CB0040959E56B4EA41A77E4A663C47@irsmsx504.ger.corp.intel.com>
Date:	Mon, 16 Mar 2009 14:34:13 +0000
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"roland@...hat.com" <roland@...hat.com>,
	"eranian@...glemail.com" <eranian@...glemail.com>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"Villacis, Juan" <juan.villacis@...el.com>,
	"ak@...ux.jf.intel.com" <ak@...ux.jf.intel.com>
Subject: RE: [patch 1/5] x86, bts: detect size of DS fields

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@...e.hu]
>Sent: Friday, March 13, 2009 12:04 PM
>To: Metzger, Markus T


>Applied your patches to tip:tracing/hw-branch-tracer, thanks
>Markus!
>
>I did a small cleanup patch - see it in this thread.
>
>One detail i noticed:
>
>static DEFINE_PER_CPU(struct ds_configuration, ds_cfg_array);
>
>That PER_CPU indirection should be removed - it's enough to have
>system-wide configuration settings. We dont generally support
>assymetric CPU capabilities in the same system, and the per_cpu
>indirection here slows the code down and obfuscates it.

I will change it to a single configuration for all cpus.


Apologies for the build fail caused by the incomplete renaming
in another patch of that series.
I had the Core i7 support patch on top of my series when I built
the kernel for testing. That patch changes the WARN to check for
the number of pebs counter reset values.

regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/