linux-kernel - linux-next - tty_io.c change breaks /dev/console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <12675.1237152004@turing-police.cc.vt.edu>
Date:	Sun, 15 Mar 2009 17:20:04 -0400
From:	Valdis.Kletnieks@...edu
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: linux-next - tty_io.c change breaks /dev/console

At boot, all attempts to open /dev/console failed.  dmesg shows:

Warning: unable to open an initial console.

from init/main.c:

        if (sys_open((const char __user *) "/dev/console", O_RDWR, 0) < 0)
                printk(KERN_WARNING "Warning: unable to open an initial console.\n");

problem originally hit in -mmotm, traced down to linux-next.
git bisect of linux-next find this:

31f8326f981117fc548d292656fa8dbed28bc42b is first bad commit
commit 31f8326f981117fc548d292656fa8dbed28bc42b
Author: Alan Cox <alan@...rguk.ukuu.org.uk>
Date:   Thu Mar 12 10:00:15 2009 +1100

    tty-fix-mismatch-in-lookup-han
    
    The lookup methods return NULL or a pointer. The caller expects an ERR_PTR.
    It seems to make sense to just use NULL and return -ENODEV here as it keeps
    the code simple and clean and the way it always used to work (effectively)
    before the restructure
    
    Problem noticed by Jiri Slaby.
    
    Signed-off-by: Alan Cox <alan@...rguk.ukuu.org.uk>

:040000 040000 e6b1ddf54e63b5b7be2bfa07c6a21a9657e91d27 1ef01e18f00a713c3a0299725c6b594da5fcffbe M      drivers

Reverting this one commit made things start working again.  I admit not
understanding why this commit broke the sys_open().


Content of type "application/pgp-signature" skipped