linux-kernel - Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d5443650903161114q4aa63bb9s405031c8a5bd0317@mail.gmail.com>
Date:	Mon, 16 Mar 2009 23:44:04 +0530
From:	Trilok Soni <soni.trilok@...il.com>
To:	Purushotam Kumar <purushotam@...com>
Cc:	davinci-linux-open-source@...ux.davincidsp.com,
	linux-kernel@...r.kernel.org, drzeus-mmc@...eus.cx
Subject: Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for 
	DaVinci/DM6446.

Hi Purshotam,

> +
> +
> +/* MMCSD Init clock in Hz in opendain mode */

s/opendain/opendrain

> +
> +static irqreturn_t mmc_davinci_irq(int irq, void *dev_id)
> +{
> +       struct mmc_davinci_host *host = (struct mmc_davinci_host *)dev_id;


Unnecessary casting from void *.

> +
> +       ret = -EBUSY;
> +       mem_size = r->end - r->start + 1;

How about using resource_size(...) ?

> +       mem = request_mem_region(r->start, mem_size, pdev->name);
> +       if (!mem)
> +               goto out;
> +
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("MMC/SD driver for Davinci MMC controller");

Adding MODULE_AUTHOR and MODULE_ALIAS would be great. You can also add
MAINTAINERS entry if you want.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/