[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.LFD.2.00.0903170919310.29264@localhost.localdomain>
Date: Tue, 17 Mar 2009 09:29:35 +0100 (CET)
From: Thomas Gleixner <tglx@...utronix.de>
To: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
cc: Ingo Molnar <mingo@...e.hu>,
Josh Boyer <jwboyer@...ux.vnet.ibm.com>,
ltt-dev@...ts.casi.polymtl.ca, danymadden@...ibm.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_desc
symbols v2
On Mon, 16 Mar 2009, Mathieu Desnoyers wrote:
> * Thomas Gleixner (tglx@...utronix.de) wrote:
> > Is this a contribution to the "most useless patch of the week"
> > contest ?
> >
> > You have my vote.
> >
>
> Count mine too ! :) Actually, this was not what it should look like.
> Here is my version. I am not totally convinced that the struct irq_desc
> is absolutely required, but in some include orders, it might matter.
I have not seen a compile failure report yet.
> However, the #endif around the EXPORT_SYMBOL is definitely needed.
Right.
> struct irq_desc *desc = irq_to_desc(irq);
> return desc ? desc->kstat_irqs[cpu] : 0;
> }
> -#endif
> EXPORT_SYMBOL(kstat_irqs_cpu);
> +#endif
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists