linux-kernel - RE: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B85A65D85D7EB246BE421B3FB0FBB59301CC30E2B1@dbde02.ent.ti.com>
Date:	Tue, 17 Mar 2009 15:44:38 +0530
From:	"Kumar, Purushotam" <purushotam@...com>
To:	Trilok Soni <soni.trilok@...il.com>
CC:	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"drzeus-mmc@...eus.cx" <drzeus-mmc@...eus.cx>
Subject: RE: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for
 DaVinci/DM6446.



> > +/* MMCSD Init clock in Hz in opendain mode */
> s/opendain/opendrain

I will make this modification while incorporating review comments.

> > +static irqreturn_t mmc_davinci_irq(int irq, void *dev_id)
> > +{
> > +       struct mmc_davinci_host *host = (struct mmc_davinci_host *)dev_id;
> Unnecessary casting from void *.

I think it always to cast void* pointer and use it.

> 
> > +
> > +       ret = -EBUSY;
> > +       mem_size = r->end - r->start + 1;
> 
> How about using resource_size(...) ?
> 
> > +       mem = request_mem_region(r->start, mem_size, pdev->name);
> > +       if (!mem)
> > +               goto out;

I could use resource_size.


> > +MODULE_LICENSE("GPL");
> > +MODULE_DESCRIPTION("MMC/SD driver for Davinci MMC controller");
> 
> Adding MODULE_AUTHOR and MODULE_ALIAS would be great. You can also add
> MAINTAINERS entry if you want.
I will add MODULE_AUTHOR and MODULE_ALIAS
-Purushotam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/