linux-kernel - Re: [PULL] x86 cpumask work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090317105121.GJ6477@elte.hu>
Date:	Tue, 17 Mar 2009 11:51:21 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	Mike Travis <travis@....com>
Subject: Re: [PULL] x86 cpumask work


* Rusty Russell <rusty@...tcorp.com.au> wrote:

> On Monday 16 March 2009 19:18:02 Ingo Molnar wrote:
> > 
> > * Rusty Russell <rusty@...tcorp.com.au> wrote:
> > > As the comments says, it can only be NULL during boot of the first CPU.
> > > 
> > > start_kernel -> check_bugs -> identify_boot_cpu -> identify_cpu
> > >   -> select_idle_routine.
> > > 
> > > Did you want me to panic if it fails?
> > 
> > Ah, ok. But i think it's very unobvious to embedd a "once per 
> > bootup" dynamic allocation like that. Please put it into a 
> > separate init routine instead. That way select_idle() [which 
> > runs during every CPU hotplug event] wont have this allocation.
> 
> There wasn't an obvious place to put the init; I've created one.
> 
> How's this?

looks perfect. Should i apply or do you want to send a pull 
request?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/