linux-kernel - Re: [PATCH 2/7] tracing: replace TP<var> with TP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903171130110.10274@gandalf.stny.rr.com>
Date:	Tue, 17 Mar 2009 11:30:38 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Christoph Hellwig <hch@...radead.org>
cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Theodore Tso <tytso@....edu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	"Martin J. Bligh" <mbligh@...igh.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Larry Woodman <lwoodman@...hat.com>,
	Jason Baron <jbaron@...hat.com>,
	Tom Zanussi <tzanussi@...il.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Jiaying Zhang <jiayingz@...gle.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 2/7] tracing: replace TP<var> with TP_<var>


On Tue, 17 Mar 2009, Christoph Hellwig wrote:

> On Tue, Mar 10, 2009 at 12:57:12AM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@...hat.com>
> > 
> > Impact: clean up
> > 
> > The macros TPPROTO, TPARGS, TPFMT, TPRAWFMT, and TPCMD all look a bit
> > ugly. This patch adds an underscore to their names.
> 
> Honestly I think they still look ugly.
> 
> >  DECLARE_TRACE(subsys_eventname,
> > -	TPPROTO(int firstarg, struct task_struct *p),
> > -	TPARGS(firstarg, p));
> > +	TP_PROTO(int firstarg, struct task_struct *p),
> > +	TP_ARGS(firstarg, p));
> 
> Compare that to a
> 
> DECLARE_TRACE(subsys_eventname,
> 	trace_proto(int firstarg, struct task_struct *p),
> 	trace_args(firstarg, p));
> 
> or even when you insist on UPPERCASE:
> 
> DECLARE_TRACE(subsys_eventname,
> 	TRACE_PROTO(int firstarg, struct task_struct *p),
> 	TRACE_ARGS(firstarg, p));

I have no attachement to the name. I can switch it to TRACE_PROTO etc.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/