linux-kernel - Re: [PATCH] tracing/ftrace: stop {irqs,preempt}soff tracers when tracing is stopped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903171757320.9036@gandalf.stny.rr.com>
Date:	Tue, 17 Mar 2009 17:59:22 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/ftrace: stop {irqs,preempt}soff tracers when
 tracing is stopped


On Tue, 17 Mar 2009, Frederic Weisbecker wrote:
> > > +	/*
> > > +	 * Stop the tracer to avoid a warning subsequent
> > > +	 * to buffer flipping failure because tracing_stop()
> > > +	 * disables the tr and max buffers, making flipping impossible
> > > +	 * in case of parallels max preempt off latencies.
> > > +	 */
> > > +	trace->stop(tr);
> > >  	/* stop the tracing. */
> > >  	tracing_stop();
> > 
> > I'm actually thinking that tracing_stop() should call the current tracer
> > "stop" function.
> > 
> > -- Steve
> 
> 
> Indeed, it could be better.
> But I think of a combination of stop() callback call plus
> ring buffer disabled because I'm not sure all tracers implement
> the stop callback.

Yes, that's what I meant. The tracing_stop should do a few things, and one
of them is to call the stop function if it exists.

> 
> Should I send a v2 based on the above?

Sure.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/