linux-kernel - Re: {PATCH] x86: print out initial max_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49BF0CA1.3010304@zytor.com>
Date:	Mon, 16 Mar 2009 19:36:17 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: {PATCH] x86: print out initial max_pfn_mapped

Yinghai Lu wrote:
> Impact: more debug info
> 
> check range that is mapped before init_memory_mapping().
> also make 64bit have max_pfn_mapped assigned before that calling
> 
> Index: linux-2.6/arch/x86/mm/init.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/mm/init.c
> +++ linux-2.6/arch/x86/mm/init.c
> @@ -65,12 +65,11 @@ static void __init find_early_table_spac
>  	 */
>  #ifdef CONFIG_X86_32
>  	start = 0x7000;
> -	e820_table_start = find_e820_area(start, max_pfn_mapped<<PAGE_SHIFT,
> -					tables, PAGE_SIZE);
> -#else /* CONFIG_X86_64 */
> +#else
>  	start = 0x8000;
> -	e820_table_start = find_e820_area(start, end, tables, PAGE_SIZE);
>  #endif
> +	e820_table_start = find_e820_area(start, max_pfn_mapped<<PAGE_SHIFT,
> +					tables, PAGE_SIZE);
>  	if (e820_table_start == -1UL)
>  		panic("Cannot find space for the kernel page tables");
>  

This doesn't seem to match anything anywhere in the description.
Furthermore, why do we even have a different starting address for
different architectures?  If anything, this starting address is way too
low (hogging ZONE_DMA and all that...)

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/