| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200903180947.36878.borntraeger@de.ibm.com> Date: Wed, 18 Mar 2009 09:47:36 +0100 From: Christian Borntraeger <borntraeger@...ibm.com> To: Christoph Hellwig <hch@...radead.org> Cc: Rusty Russell <rusty@...tcorp.com.au>, Anthony Liguori <aliguori@...ibm.com>, linux-kernel@...r.kernel.org, hare@...e.de Subject: Re: VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk Am Wednesday 18 March 2009 07:09:19 schrieb Christoph Hellwig: > Currently virtio-blk just sends down the payload for packet command > requests, setting the VIRTIO_BLK_T_SCSI_CMD flag in the type field and > zeroing out the sector field. > > But to make any sense of the payload of a packet command we need the > scsi command block (request->cmd) which specifies the operation, > location and length for this command. > > All backends that I checked just fail VIRTIO_BLK_T_SCSI_CMD commands, so > AFAICS no harm is done. But should we really keep this broken support > in the protocol around? If we do want to support packet commands in > the future we should probably just add the command as the first S/G list > entry. Hannes did some implementation for SCSI command passthrough: https://lists.linux-foundation.org/pipermail/virtualization/2008-August/011629.html After some addon fix this was working pretty well. I dont know why Hannes never pushed the final version upstream. Christian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists